feat: update nitro signatures for update and digest methods

margelo · Jan 29, 2025 · 173f828 · 173f828
1 parent 00778cb
commit 173f828
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 10 deletions.
diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
@@ -2008,4 +2008,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: bcfd7840a8f657993e5e9504fdac2d1397cbc14a
 
-COCOAPODS: 1.16.2
+COCOAPODS: 1.15.2
diff --git a/packages/react-native-quick-crypto/cpp/hash/HybridHash.cpp b/packages/react-native-quick-crypto/cpp/hash/HybridHash.cpp
@@ -54,15 +54,17 @@ HybridHash::createHash(const std::string& hashAlgorithm)
 }
 
 void
-HybridHash::update()
+HybridHash::update(const std::shared_ptr<ArrayBuffer>& data)
 {
   // TODO
 }
 
-void
-HybridHash::digest()
+std::string
+HybridHash::digest(const std::optional<std::string>& encoding)
 {
   // TODO
+
+  return "mocked_hash_digest_result";
 }
 
 } // namespace margelo::nitro::crypto
diff --git a/packages/react-native-quick-crypto/cpp/hash/HybridHash.hpp b/packages/react-native-quick-crypto/cpp/hash/HybridHash.hpp
@@ -24,8 +24,8 @@ class HybridHash : public HybridHashSpec
   // Methods
   std::shared_ptr<ArrayBuffer> createHash(
     const std::string& algorithm) override;
-  void update() override;
-  void digest() override;
+  void update(const std::shared_ptr<ArrayBuffer>& data) override;
+  std::string digest(const std::optional<std::string>& encoding) override;
 
 private:
   // Properties

diff --git a/packages/react-native-quick-crypto/nitrogen/generated/shared/c++/HybridHashSpec.hpp b/packages/react-native-quick-crypto/nitrogen/generated/shared/c++/HybridHashSpec.hpp
@@ -18,6 +18,7 @@ namespace NitroModules { class ArrayBuffer; }
 
 #include <NitroModules/ArrayBuffer.hpp>
 #include <string>
+#include <optional>
 
 namespace margelo::nitro::crypto {
 
@@ -51,8 +52,8 @@ namespace margelo::nitro::crypto {
     public:
       // Methods
       virtual std::shared_ptr<ArrayBuffer> createHash(const std::string& algorithm) = 0;
-      virtual void update() = 0;
-      virtual void digest() = 0;
+      virtual void update(const std::shared_ptr<ArrayBuffer>& data) = 0;
+      virtual std::string digest(const std::optional<std::string>& encoding) = 0;
 
     protected:
       // Hybrid Setup

diff --git a/packages/react-native-quick-crypto/src/specs/hash.nitro.ts b/packages/react-native-quick-crypto/src/specs/hash.nitro.ts
@@ -2,6 +2,6 @@ import type { HybridObject } from 'react-native-nitro-modules';
 
 export interface Hash extends HybridObject<{ ios: 'c++'; android: 'c++' }> {
   createHash(algorithm: string): ArrayBuffer;
-  update(): void;
-  digest(): void;
+  update(data: ArrayBuffer): void;
+  digest(encoding?: string): string;
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2008,4 +2008,4 @@ SPEC CHECKSUMS:

		PODFILE CHECKSUM: bcfd7840a8f657993e5e9504fdac2d1397cbc14a

		COCOAPODS: 1.16.2
		COCOAPODS: 1.15.2