Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android CMakeLists.txt for newer versions of react-native #74

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

renanmav
Copy link
Member

@renanmav renanmav commented Feb 3, 2025

@renanmav renanmav force-pushed the renan/fix-android-cmakelist branch from 79d99fe to 0a47a46 Compare February 3, 2025 15:27
@renanmav renanmav force-pushed the renan/fix-android-cmakelist branch from 9b6a795 to 2f1888b Compare February 3, 2025 15:51
@renanmav renanmav marked this pull request as ready for review February 3, 2025 15:52
@renanmav
Copy link
Member Author

renanmav commented Feb 3, 2025

I don't know why CI is failing to find react android and hermes:

FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':configureCMakeDebug[arm64-v8a]'.
> Could not resolve all files for configuration ':debugCompileClasspath'.
   > Could not find com.facebook.react:react-android:.
     Required by:
         project :
   > Could not find com.facebook.react:hermes-android:.
     Required by:
         project :

I can take a look in a follow up.

Copy link
Member

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it builds, lgtm

@renanmav renanmav merged commit 3e6fc22 into main Feb 4, 2025
3 checks passed
@renanmav renanmav deleted the renan/fix-android-cmakelist branch February 4, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android/Expo SDK52 Both Architectures break react-native-bignumber
2 participants