Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled naming-convention eslint rule #451

Merged
merged 1 commit into from
Jan 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import preferArrowFunctions from "eslint-plugin-prefer-arrow-functions";
import prettierRecommended from "eslint-plugin-prettier/recommended";
import tseslint from "typescript-eslint";

/* eslint-disable @typescript-eslint/naming-convention -- Not applicable to this file */

export default tseslint.config(
js.configs.recommended,
prettierRecommended,
Expand Down Expand Up @@ -46,34 +44,6 @@ export default tseslint.config(
"@typescript-eslint/explicit-module-boundary-types": "error",
"@typescript-eslint/init-declarations": "error",
"@typescript-eslint/method-signature-style": ["error", "method"],
"@typescript-eslint/naming-convention": [
"error",
{
filter: {
match: false,
regex:
"^(Backspace|Ctrl-.*|data-.*|DefinitionExtension|Enter|ImageReferenceExtension|LinkReferenceExtension|Mod-.*|Shift-.*|Tab)$",
},
format: ["camelCase"],
leadingUnderscore: "allow",
selector: "default",
trailingUnderscore: "allow",
},
{
format: ["camelCase", "PascalCase"],
selector: "import",
},
{
format: ["camelCase", "UPPER_CASE"],
leadingUnderscore: "allow",
selector: "variable",
trailingUnderscore: "allow",
},
{
format: ["PascalCase"],
selector: "typeLike",
},
],
"@typescript-eslint/no-import-type-side-effects": "error",
"@typescript-eslint/no-shadow": "error",
"@typescript-eslint/no-unnecessary-parameter-property-assignment":
Expand Down Expand Up @@ -225,5 +195,3 @@ export default tseslint.config(
},
},
);

/* eslint-enable @typescript-eslint/naming-convention */
2 changes: 0 additions & 2 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export default {
coverageDirectory: "coverage",
coverageProvider: "babel",
moduleNameMapper: {
// eslint-disable-next-line @typescript-eslint/naming-convention -- The key is a module name
"prosemirror-unified":
"<rootDir>/node_modules/prosemirror-unified/dist/prosemirror-unified.js",
},
Expand All @@ -17,7 +16,6 @@ export default {
testEnvironment: "jsdom",
testMatch: ["<rootDir>/__tests__/**/*.test.ts"],
transform: {
// eslint-disable-next-line @typescript-eslint/naming-convention -- The key is a glob
"^.+\\.(j|t)s$": [
"ts-jest",
{
Expand Down
1 change: 0 additions & 1 deletion src/syntax-extensions/HeadingExtension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ export class HeadingExtension extends NodeExtension<Heading> {
proseMirrorSchema: Schema<string, string>,
): Record<string, Command> {
const keymap: Record<string, Command> = {
// eslint-disable-next-line @typescript-eslint/naming-convention -- This is a key
"#": HeadingExtension.headingLevelCommandBuilder(
proseMirrorSchema,
+1,
Expand Down
4 changes: 0 additions & 4 deletions webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable @typescript-eslint/naming-convention -- Not applicable to this config file */

function createConfig(libraryType, extension) {
return {
devtool: "source-map",
Expand Down Expand Up @@ -50,5 +48,3 @@ function createConfig(libraryType, extension) {
}

export default [createConfig("module", "js"), createConfig("commonjs2", "cjs")];

/* eslint-enable */
Loading