Add ability to override tmp directory + fix tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More descriptive and the starting dot will hide it from Unix systems for when you choose a new tmp dir. + put program and file name into const variables
took a lot of brain power to restructure this to work well 🥲
...rather than getting last modified folder. This makes it more reliable and make more sense especially when using a custom attempts folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to override the directory used for attempts allows flexibility in the usage of
atmptsuch as a general purpose new-project-maker by adding e.g.ATMPT_TMP_DIR=~/myprojectsto your environment.This also allows the tests to be more consistent by running conflicting ones in separate directories so they do not clash.