Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip text spans when traversing the DOM #403

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

marc2332
Copy link
Owner

Closes #402

@marc2332 marc2332 added enhancement 🔥 New feature or request performance ⚡️ Performance improvement ⚡️ labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2a95293) 53.26% compared to head (1ce59dd) 53.31%.
Report is 2 commits behind head on main.

Files Patch % Lines
crates/core/src/layout/layers.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   53.26%   53.31%   +0.05%     
==========================================
  Files         143      143              
  Lines       12612    12628      +16     
==========================================
+ Hits         6718     6733      +15     
- Misses       5894     5895       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review November 29, 2023 20:10
@marc2332 marc2332 merged commit 4d84262 into main Nov 30, 2023
5 checks passed
@marc2332 marc2332 deleted the feat/skip-text-spans-when-traversing-the-dom branch November 30, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request performance ⚡️ Performance improvement ⚡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Skip text spans when traversing the dom
1 participant