Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Redesign devtools inspector #1056

Merged
merged 8 commits into from
Jan 22, 2025
Merged

feat: Redesign devtools inspector #1056

merged 8 commits into from
Jan 22, 2025

Conversation

marc2332
Copy link
Owner

Depends on #1053

@marc2332 marc2332 added enhancement 🔥 New feature or request devtools labels Jan 17, 2025
@marc2332 marc2332 added this to the 0.3.0 milestone Jan 17, 2025
@marc2332 marc2332 self-assigned this Jan 17, 2025
@github-actions GitHub Actions
Copy link

Benchmark for 33d8b60

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.6±0.71ms 105.7±0.66ms -0.84%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.8±0.51ms 25.0±1.24ms +0.81%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1390.7±12.00µs 1397.7±9.76µs +0.50%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.6±0.90µs 135.8±6.20µs +2.41%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.9±0.43ms 24.3±0.55ms +1.67%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1682.6±5.95µs 1703.8±23.97µs +1.26%
benchmarks/size=19531 depth=7 wide=5 mode=cached 316.3±4.83µs 318.4±10.03µs +0.66%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.02ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 416.2±124.22µs 411.6±57.69µs -1.11%
benchmarks/size=54241 depth=5 wide=15 mode=cached 253.0±12.05µs 250.5±13.15µs -0.99%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.1±0.23ms 6.3±0.06ms -11.27%

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 296 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (d10f700) to head (b6771a3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/devtools/src/tabs/layout.rs 0.00% 143 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 76 Missing ⚠️
crates/devtools/src/node.rs 0.00% 40 Missing ⚠️
crates/devtools/src/tabs/style.rs 0.00% 19 Missing ⚠️
crates/devtools/src/property.rs 0.00% 11 Missing ⚠️
crates/components/src/tabs.rs 0.00% 6 Missing ⚠️
crates/torin/src/values/size.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
- Coverage   73.53%   73.06%   -0.47%     
==========================================
  Files         220      220              
  Lines       26837    27005     +168     
==========================================
- Hits        19734    19732       -2     
- Misses       7103     7273     +170

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 changed the title feat: Show role alongside tag in devtools inspector feat: Redesign devtools inspector Jan 18, 2025
Base automatically changed from feat/show-role-alongside-tag-in-devtools-inspector to main January 18, 2025 10:23
@github-actions GitHub Actions
Copy link

Benchmark for 8a835a7

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.7±1.60ms 108.8±0.48ms +1.02%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 26.6±0.60ms 24.2±0.92ms -9.02%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1393.6±17.17µs 1392.3±20.10µs -0.09%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.9±2.93µs 133.1±2.83µs -1.33%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.1±0.33ms 24.1±0.31ms 0.00%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1687.5±15.11µs 1691.8±57.80µs +0.25%
benchmarks/size=19531 depth=7 wide=5 mode=cached 318.1±8.08µs 313.5±4.86µs -1.45%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.04ms 2.6±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 417.0±153.71µs 412.4±146.23µs -1.10%
benchmarks/size=54241 depth=5 wide=15 mode=cached 262.9±25.92µs 248.3±13.27µs -5.55%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.05ms 6.4±0.06ms +3.23%

@github-actions GitHub Actions
Copy link

Benchmark for 33430c5

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.7±2.20ms 105.9±0.66ms -0.75%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.5±0.46ms 25.5±0.89ms +4.08%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1377.1±25.52µs 1471.1±6.11µs +6.83%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.7±13.30µs 143.4±0.78µs +6.46%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.2±0.39ms 24.5±0.38ms +1.24%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1684.7±28.72µs 1727.7±24.37µs +2.55%
benchmarks/size=19531 depth=7 wide=5 mode=cached 314.2±15.81µs 309.1±3.46µs -1.62%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.6±0.03ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 414.4±182.74µs 424.3±93.67µs +2.39%
benchmarks/size=54241 depth=5 wide=15 mode=cached 243.2±9.27µs 250.9±150.13µs +3.17%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.07ms 6.4±0.05ms 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for 58571ae

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 108.9±1.59ms 107.1±0.57ms -1.65%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.7±1.06ms 25.6±1.13ms -0.39%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1385.0±16.38µs 1382.0±17.25µs -0.22%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.5±2.24µs 134.3±3.05µs -0.15%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.6±0.53ms 25.0±0.46ms +1.63%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1709.7±39.69µs 1729.5±23.26µs +1.16%
benchmarks/size=19531 depth=7 wide=5 mode=cached 324.8±17.36µs 317.1±6.73µs -2.37%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.04ms 2.6±0.08ms -3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 418.0±180.82µs 419.8±177.81µs +0.43%
benchmarks/size=54241 depth=5 wide=15 mode=cached 259.4±18.60µs 260.8±26.32µs +0.54%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.20ms 6.5±0.27ms +3.17%

@github-actions GitHub Actions
Copy link

Benchmark for edd1e8b

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.5±2.45ms 105.1±0.30ms -0.38%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.3±0.65ms 25.8±1.04ms +1.98%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1394.3±19.03µs 1447.6±25.14µs +3.82%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.2±3.07µs 138.9±1.56µs +2.74%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.6±0.26ms 24.5±0.27ms -0.41%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1685.3±36.89µs 1703.1±12.78µs +1.06%
benchmarks/size=19531 depth=7 wide=5 mode=cached 313.9±6.54µs 315.2±8.20µs +0.41%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.6±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 414.1±150.93µs 415.8±139.11µs +0.41%
benchmarks/size=54241 depth=5 wide=15 mode=cached 246.8±12.11µs 250.7±17.52µs +1.58%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.18ms 6.3±0.15ms 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for 8647738

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.4±0.60ms 106.2±0.90ms +0.76%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.8±0.73ms 24.0±0.72ms +0.84%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1374.0±25.02µs 1371.0±7.76µs -0.22%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.8±3.77µs 133.6±1.21µs -0.89%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.0±0.96ms 24.3±0.45ms +1.25%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1716.5±43.71µs 1721.5±47.12µs +0.29%
benchmarks/size=19531 depth=7 wide=5 mode=cached 312.2±4.23µs 312.2±12.45µs 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.03ms 2.6±0.02ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 411.8±33.47µs 417.5±155.79µs +1.38%
benchmarks/size=54241 depth=5 wide=15 mode=cached 249.7±122.13µs 248.1±14.28µs -0.64%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.19ms 6.4±0.11ms +1.59%

@marc2332 marc2332 marked this pull request as ready for review January 22, 2025 20:11
@github-actions GitHub Actions
Copy link

Benchmark for ab73c24

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.4±1.01ms 107.0±0.92ms +0.56%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 26.2±1.61ms 25.6±1.59ms -2.29%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1424.9±101.48µs 1444.2±11.19µs +1.35%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.3±8.20µs 139.9±4.49µs +4.17%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.3±0.92ms 24.3±0.89ms -3.95%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1764.1±173.07µs 1704.5±105.35µs -3.38%
benchmarks/size=19531 depth=7 wide=5 mode=cached 352.9±26.18µs 359.8±37.06µs +1.96%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.22ms 2.7±0.18ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 415.4±184.07µs 411.5±90.10µs -0.94%
benchmarks/size=54241 depth=5 wide=15 mode=cached 331.9±60.09µs 295.0±58.52µs -11.12%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.9±0.53ms 6.5±0.45ms -5.80%

@marc2332 marc2332 merged commit 2bca0ad into main Jan 22, 2025
7 of 8 checks passed
@marc2332 marc2332 deleted the feat/redesigned-devtools-inspector branch January 22, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marc2332 marc2332

Labels
devtools enhancement 🔥 New feature or request
Projects
Freya Planning
Status: Done
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@marc2332