Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Rc<Refcell<T>> instead of Arc<Mutex<T>> when sharing the DOM #1052

Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 15, 2025

No description provided.

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Jan 15, 2025
@marc2332 marc2332 added this to the 0.3.0 milestone Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.92%. Comparing base (b508749) to head (725a6c4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   74.91%   74.92%           
=======================================
  Files         220      220           
  Lines       25703    25700    -3     
=======================================
  Hits        19256    19256           
+ Misses       6447     6444    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review January 18, 2025 10:21
@marc2332 marc2332 merged commit 9a8a25f into main Jan 18, 2025
6 checks passed
@marc2332 marc2332 deleted the refactor/use-rc-refcell-instead-of-arc-mutex-for-shared-dom branch January 18, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal impovement👍 Internal code improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant