Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support a11y_member_of #1040

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 12, 2025

Depends on #1039

  • Adds a11y_member_of
  • Open dropdowns will close when the focused node is not part of them

@marc2332 marc2332 added this to the 0.3.0 milestone Jan 12, 2025
@marc2332 marc2332 self-assigned this Jan 12, 2025
@marc2332 marc2332 marked this pull request as draft January 12, 2025 11:11
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 85.06787% with 33 lines in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (94e463a) to head (d37bd3c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/renderer/src/accessibility.rs 0.00% 21 Missing ⚠️
crates/renderer/src/app.rs 0.00% 4 Missing ⚠️
crates/hooks/src/use_focus.rs 76.92% 3 Missing ⚠️
crates/testing/src/test_handler.rs 88.88% 3 Missing ⚠️
crates/components/src/dropdown.rs 99.28% 1 Missing ⚠️
crates/state/src/accessibility.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
+ Coverage   73.06%   73.39%   +0.33%     
==========================================
  Files         220      218       -2     
  Lines       27005    27408     +403     
==========================================
+ Hits        19732    20117     +385     
- Misses       7273     7291      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/improve-dropdown-styling to main January 18, 2025 10:23
@marc2332 marc2332 marked this pull request as ready for review January 27, 2025 21:03
@marc2332 marc2332 merged commit 0fbf732 into main Jan 27, 2025
7 checks passed
@marc2332 marc2332 deleted the feat/accessibility-member-of-support branch January 27, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant