Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Type safety for use_animation #1035

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 5, 2025

Internally, use_animation now only animates 1 value, although because the trait AnimatedValue is now implemented for tuples with up to 18 items you can still group multiple values

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jan 5, 2025
@marc2332 marc2332 added this to the 0.3.0 milestone Jan 5, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 75.73964% with 41 lines in your changes missing coverage. Please review.

Project coverage is 74.84%. Comparing base (05b7d57) to head (1386482).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/hooks/src/use_animation.rs 64.35% 36 Missing ⚠️
crates/components/src/loader.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   74.78%   74.84%   +0.06%     
==========================================
  Files         219      219              
  Lines       25433    25554     +121     
==========================================
+ Hits        19020    19126     +106     
- Misses       6413     6428      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review January 8, 2025 14:01
@marc2332 marc2332 merged commit 5a34889 into main Jan 9, 2025
4 checks passed
@marc2332 marc2332 deleted the feat/type-safety-use-animation branch January 9, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant