Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify use_asset_cacher hook #1032

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jan 1, 2025

No description provided.

@marc2332 marc2332 added enhancement 🔥 New feature or request internal impovement👍 Internal code improvements labels Jan 1, 2025
@marc2332 marc2332 added this to the 0.3.0 milestone Jan 1, 2025
@@ -36,7 +40,7 @@ pub enum AssetAge {

impl Default for AssetAge {
fn default() -> Self {
Self::Duration(Duration::from_secs(3600)) // 1h
Self::Duration(Duration::from_secs(10)) // 1h
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to 3600

@@ -41,6 +41,7 @@ nokhwa = { version = "0.10.7", features = ["input-native"], optional = true }
paste = "1.0.14"
bitflags = "2.4.1"
bytes = "1.5.0"
tracing.workspace = true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tracing.workspace = true
tracing = { workspace = true }

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request internal impovement👍 Internal code improvements
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant