Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip missing maps instead of raising error #549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Jan 27, 2025

Summary

This PR makes it possible to skip missing maps when downloading.
e.g. if there is a sheet missing from a tilelayer we no longer error, instead we print a warning and move on to the next one.

This behaviour is off by default, but can be turned on by setting error_on_missing_maps=True.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/download/tile_merging.py 33.33% 4 Missing ⚠️
mapreader/download/sheet_downloader.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 78.93% <28.57%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/download/sheet_downloader.py 83.38% <0.00%> (ø)
mapreader/download/tile_merging.py 73.97% <33.33%> (-3.97%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant