-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies #192
Updated dependencies #192
Conversation
babel-loader fixed at 7.1.1 due to <babel/babel-loader#505>
Ok I've broken the tests, arrrgh. However it does build ok so if someone has time to check that nothings broken in the app, while I fix the tests that would be much appreciated (CC @gregorywolanski @pjsier ). You can either checkout the branch or test it here https://38-84182601-gh.circle-artifacts.com/0/tmp/circle-artifacts.W3CuZgL/build/index.html#12.24/47.3718/8.5481 |
I've fixed the failing tests and also removed nodejs v4 for the time being. As it was causing all the tests to fail. There is some odd error with the install in v4 which I'll look into later in the week.
|
Conflicts: src/components/Toolbar.jsx
The latest branch build is here https://44-84182601-gh.circle-artifacts.com/0/tmp/circle-artifacts.NgEXZgj/build/index.html @keum you kindly offered to test maputnik over in ticket #181. In this pull request I've updated most of the library dependencies maputnik uses. Given our lack of test coverage it'd be great if you could give it a test before I merge the changes. Basically we're looking for anything that is broken now and wasn't in the current live version at https://maputnik.github.io/ So basically test the app here https://44-84182601-gh.circle-artifacts.com/0/tmp/circle-artifacts.NgEXZgj/build/index.html and leave any feedback in this ticket. Any data will be lost so make sure you export any styles you want to keep. |
This fixes those errors and adds a package-lock.json
@orangemug One thing I noticed was that when Mapzen basema, Tilezen option doesn't show on yours compared to https://maputnik.github.io/editor/#12.24/47.3718/8.5481 I've added my own vector tiles from DigitalOcean and styled them and export to preview and no problem with it. |
Good spot, that's correct, we removed that in #172 because it was no longer functional. We have a ticket to add it back in #153.
That'll be due to permisisons of the mapbox key. So not an issue but thanks for raising it.
Thats what I like to hear :) Thanks for testing @keum, the hard work is much appreciated. |
For future reference we also removed node.js v4/v5 support, node v5 is no longer supported and v4 was causing issues. Since v4 is in maintenance due to end April 2018 (see https://github.com/nodejs/Release) I decided to remove support. There were also some breaking API changes to |
Updated most of the dependencies, with the exception of