feat: make `setAccessToken(null)` obsolete #593

OleksiiZubko · 2025-01-05T01:53:01Z

Description

According to comment #25 (comment) , we can drop supporting this.

Related-To #25

Checklist

I have tested this on a device/simulator for each compatible OS
I formatted JS and TS files with running yarn lint:eslint:fix in the root folder
I have run tests via yarn test in the root folder
I updated the documentation with running yarn codegen in the root folder
I mentioned this change in CHANGELOG.md
I added/updated a sample (/packages/examples)

Screenshot OR Video

Signed-off-by: Oleksii Zubko <[email protected]>

KiwiKilian · 2025-01-05T07:55:53Z

Thanks for having a look into this!

Is there any benefit in exposing createMapLibreInstance? Preferably one wouldn't have to call a method imperatively from the consumer side at all. Could we call this from the Constructor or something similar, then we wouldn't even need to bring this into the JS context? As we currently recommend to call this as early as possible, I don't see a downside of calling it ourselves.

OleksiiZubko · 2025-01-05T10:11:26Z

Yep, makes sense. Let me try

OleksiiZubko · 2025-01-05T12:34:10Z

@KiwiKilian I've updated it, please let me know if any changes are needed.

KiwiKilian · 2025-01-05T12:43:48Z

Awesome, will try this later. I think a deprecation in JS is missing?

Signed-off-by: Oleksii Zubko <[email protected]>

OleksiiZubko · 2025-01-05T12:47:24Z

you're right, updated. Thanks!

KiwiKilian · 2025-01-05T13:09:56Z

I really like this approach, makes usage of the library much easier.

@tyrauber how would you feel about removing it now? This would mean for anyone using this library to remove their setAccessToken(null) line. Anyone using this and setting a proper value shouldn't be using this library anyways. Therefor I'm not sure if a deprecation is helping anyone.

KiwiKilian · 2025-01-05T13:13:05Z

@OleksiiZubko does this work with the latest changes for you? React Native example app on Android crashes on launch for me.

OleksiiZubko · 2025-01-05T13:14:32Z

Yes, I've tested on my real Android device and ios simulator.

OleksiiZubko · 2025-01-05T13:20:00Z

I'm testing like this:

yarn example:expo purge && yarn && yarn example:expo android (and yarn example:expo ios)

...

Should I build and run something another?

OleksiiZubko · 2025-01-05T13:28:54Z

@KiwiKilian example:react-native crashes, I'm investigating.

KiwiKilian · 2025-01-05T13:34:57Z

Yes was experiencing the same. Expo works, but not RN. Can you check if RN works right now on beta?

OleksiiZubko · 2025-01-05T13:37:47Z

on beta works, no icons in the menu, but I see a map.

Signed-off-by: Oleksii Zubko <[email protected]>

OleksiiZubko · 2025-01-05T18:14:55Z

@KiwiKilian, I've fixed the crash.

I tested in this way on my real device:

git clean -fdx && yarn
yarn example:react-native android
yarn example:expo android

No crash observed and I see the Map.

Please let me know if I should build&test something else.

docs/guides/MLRNModule.md

ios/MLRN/MLRNModule.m

KiwiKilian · 2025-01-05T20:11:25Z

The fix looks great and works fine now on Expo and React Native. I've pushed a migration note. Now lets wait for feedback on removal or deprecation by @tyrauber.

KiwiKilian · 2025-01-05T20:21:07Z

This would als resolve #13, right?

Signed-off-by: Oleksii Zubko <[email protected]>

KiwiKilian

Looking good, if we stay with deprecations I wouldn't require anymore changes. Awesome first time contribution, highly appreciate your work!

tyrauber · 2025-01-06T18:54:31Z

Yeah, this is fantastic! I'd say merge. Let's get this in 10.0.0. Thanks so much @OleksiiZubko OleksiiZubko

KiwiKilian · 2025-01-06T20:22:19Z

I'm tracking deprecations to be removed in v11 in #580.

# [10.0.0-beta.18](v10.0.0-beta.17...v10.0.0-beta.18) (2025-01-06) ### Features * make `setAccessToken(null)` obsolete ([#593](#593)) ([df44b48](df44b48))

github-actions · 2025-01-06T20:28:17Z

🎉 This PR is included in version 10.0.0-beta.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ts-ignore

# [10.0.0](v9.1.0...v10.0.0) (2025-01-14) ### Bug Fixes * `VectorSource` `onPress` returning null geometry on Android ([250ee6f](250ee6f)), closes [#538](#538) * `VectorSource` `onPress` returning null geometry on Android ([a130786](a130786)), closes [#538](#538) * add @babel/plugin-transform-private-methods for jest ([3a2188f](3a2188f)) * add generic expo config plugin to remove duplicate signature ([#453](#453)) ([2671381](2671381)) * added GeometryCollection to GeoJSONUtils ([#556](#556)) ([e6b7a66](e6b7a66)) * allow MapView and Images to have no children ([#521](#521)) ([1e35bf6](1e35bf6)) * allow resetting contentInset with 0 ([#468](#468)) ([1fe42c6](1fe42c6)) * android example crashing on launch ([#372](#372)) ([aeef5c3](aeef5c3)) * cleanup yarn setup ([#463](#463)) ([d9a4d30](d9a4d30)) * corepack enable on publish workflow ([2d13f33](2d13f33)) * correct types in MapView ([#268](#268)) ([0ea35c4](0ea35c4)) * disable code signing for release builds ([b3cf088](b3cf088)) * disable library code signing ([22030dd](22030dd)) * empty pbxproj and dwarf-with-dsym plugin config for EAS ([#458](#458)) ([0d54b46](0d54b46)) * expo-app should load library from workspace:. ([016b44a](016b44a)) * export custom header methods ([#552](#552)) ([58abdb0](58abdb0)), closes [#551](#551) * group dependabot commits by core, dev and example ([#165](#165)) ([b697978](b697978)) * keep [@ts-ignore](https://github.com/ts-ignore) for headingIcon in library [#476](#476) ([#477](#477)) ([ef62454](ef62454)) * make `follow` props on `Camera` deterministic ([#550](#550)) ([e9256e7](e9256e7)) * make MarkerView props with defaults optional ([#460](#460)) ([185cf3e](185cf3e)) * plugin for debug simulator ([#164](#164)) ([06b23d4](06b23d4)) * remove AbortController test mock ([#403](#403)) ([698b558](698b558)) * round compass margins and attribution position to nearest integers [android] ([#294](#294)) ([c89c842](c89c842)) * setMaxAnimationFps on null ([#440](#440)) ([2884256](2884256)) * style expressions ([#466](#466)) ([2202908](2202908)) * trigger release after npm maintenance ([#548](#548)) ([f0fca00](f0fca00)) * types of `getPointInView` and `getCoordinateFromView` ([#601](#601)) ([c7537b5](c7537b5)) * updated Mapbox callstack check for iOS custom headers to check for MapLibre instead ([#461](#461)) ([a6d6216](a6d6216)) * use UIManager exported from react-native ([#511](#511)) ([a4030b5](a4030b5)) * yarn implementation ([#419](#419)) ([39233b1](39233b1)) ### Continuous Integration * add semantic release ([#526](#526)) ([069b6c5](069b6c5)) ### Features * add Expo plugin props ([#589](#589)) ([51fbb00](51fbb00)) * align react and react-native versions for development ([b92abfe](b92abfe)) * allow using google location engine on Android ([#586](#586)) ([92ffdb7](92ffdb7)) * configure packages/examples ([c4510c3](c4510c3)) * drop `MapLibreGL` naming and deprecate `export default` ([#567](#567)) ([aa0c73d](aa0c73d)) * export RegionPayload and MapLibreRNEvent types ([#544](#544)) ([b342f1b](b342f1b)) * extract android UserLocation FPS ([#428](#428)) ([8c0abaa](8c0abaa)) * make `setAccessToken(null)` obsolete ([#593](#593)) ([df44b48](df44b48)) * make Camera pure ([#471](#471)) ([23ecf88](23ecf88)) * MapLibre Android SDK 11.5.0 ([#455](#455)) ([042b759](042b759)) * monorepo configuration ([343e7ac](343e7ac)) * mv example packages/react-native-app ([5c9d3d0](5c9d3d0)) * mv examples, styles, assets, utils and scenes to packages/examples ([13600fe](13600fe)) * packages/expo-app ([c01abd5](c01abd5)) * remove deprecations ([#543](#543)) ([0c41ada](0c41ada)) * remove duplicate of `OfflinePackStatus` type ([#542](#542)) ([9e231b7](9e231b7)) * remove Style component ([#547](#547)) ([9d4c458](9d4c458)) * remove style property enums ([#558](#558)) ([b89a0dd](b89a0dd)) * setup build step ([#504](#504)) ([a017d64](a017d64)) * shared dependencies through packages/examples ([01a9586](01a9586)) * support new arch through interop layer ([#483](#483)) ([951e9cf](951e9cf)) * unify `MapView`s `styleURL` and `styleJSON` to `mapStyle` ([#559](#559)) ([7d22f16](7d22f16)) * update maplibre native version ([#61](#61)) ([25c418a](25c418a)) * upgrade [@Turf](https://github.com/turf) to v7 and remove geo utils ([#478](#478)) ([a45fc55](a45fc55)) * upgrade Android gradle setup ([#539](#539)) ([761ae0d](761ae0d)) * upgrade dependencies ([#535](#535)) ([047f87f](047f87f)) * upgrade MapLibre Native ([#563](#563)) ([d2b7f5d](d2b7f5d)) * upgrade MapLibre Native Android to v11.8.0 ([#597](#597)) ([410d0c3](410d0c3)) * upgrade MapLibre Native iOS to v6.10.0 ([#598](#598)) ([b596c76](b596c76)) * use `withPodfile` instead of `withDangerousMod` in Expo Plugin ([#587](#587)) ([56d02e1](56d02e1)) ### BREAKING CHANGES * remove `styleURL` and `styleJSON` from `MapView`, use `mapStyle` instead * Removed style property enums * Remove `Style` component, use `styleJSON` of `MapView` instead * - Deprecated `UserTrackingModes` is removed in favor of `UserTrackingMode` - Removed deprecated `setCamera` from `MapView` - Removed deprecated `byId` methods from `ShapeSource` - Removed deprecated `children` from `SymbolSource` - Removed deprecated `assets` key from `Images` - Removed deprecated event keys * Replace OfflineProgressStatus with OfflinePackStatus * Upgrade native packages and migrate components * ci: move native builds to review * ci: run release immediate for debugging * ci: use android working directory for build * docs: remove RELEASE.md * chore: remove manual changelog task * ci: enable release on beta branch * ci: keep default tagFormat * ci: setup npm tag fixes * ci: run review on mr to beta * ci: run fix tags on beta * ci: fix name * ci: clarify workflow_call * ci: disable debugging * ci: run fix tags in pr * ci: setup fix tags to run on beta * docs: prepare changelog for semantic-release * ci: remove fix npm tags workflow

chore: deprecate access token support

e8c89bd

Signed-off-by: Oleksii Zubko <[email protected]>

OleksiiZubko force-pushed the feat/deprecate-access-token-support branch from 8529097 to e8c89bd Compare January 5, 2025 02:03

OleksiiZubko force-pushed the feat/deprecate-access-token-support branch from 056e8c4 to d7e367e Compare January 5, 2025 12:31

chore: remove exposing createMapLibreInstance

f0e581c

Signed-off-by: Oleksii Zubko <[email protected]>

OleksiiZubko force-pushed the feat/deprecate-access-token-support branch from d7e367e to f0e581c Compare January 5, 2025 12:46

chore: fix example:react-native crash

a462027

Signed-off-by: Oleksii Zubko <[email protected]>

OleksiiZubko force-pushed the feat/deprecate-access-token-support branch from 5f020cd to a462027 Compare January 5, 2025 18:06

KiwiKilian reviewed Jan 5, 2025

View reviewed changes

docs/guides/MLRNModule.md Outdated Show resolved Hide resolved

KiwiKilian reviewed Jan 5, 2025

View reviewed changes

ios/MLRN/MLRNModule.m Show resolved Hide resolved

docs: add setAccessToken migration

908c891

chore: remove todo

b3a3dc1

KiwiKilian changed the title ~~chore: deprecate access token support~~ feat: make setAccessToken(null) obsolete Jan 5, 2025

KiwiKilian requested a review from tyrauber January 5, 2025 20:15

chore: resolve review comments

bfd4a77

Signed-off-by: Oleksii Zubko <[email protected]>

KiwiKilian self-requested a review January 5, 2025 20:41

chore: remove todo

0ddd4de

Signed-off-by: Oleksii Zubko <[email protected]>

KiwiKilian approved these changes Jan 5, 2025

View reviewed changes

This was linked to issues Jan 6, 2025

Decide how to handle the upstream Android divergences #13

Closed

Remove broken mapbox URL support #25

Closed

KiwiKilian merged commit df44b48 into maplibre:beta Jan 6, 2025
13 checks passed

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025

chore(release): 10.0.0-beta.18 [skip ci]

7159ba1

# [10.0.0-beta.18](v10.0.0-beta.17...v10.0.0-beta.18) (2025-01-06) ### Features * make `setAccessToken(null)` obsolete ([#593](#593)) ([df44b48](df44b48))

github-actions bot added the Released on @beta label Jan 6, 2025

OleksiiZubko deleted the feat/deprecate-access-token-support branch January 6, 2025 23:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: make `setAccessToken(null)` obsolete #593

feat: make `setAccessToken(null)` obsolete #593

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

KiwiKilian commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

KiwiKilian commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

KiwiKilian left a comment •

edited

Loading

tyrauber commented Jan 6, 2025

KiwiKilian commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

feat: make setAccessToken(null) obsolete #593

feat: make setAccessToken(null) obsolete #593

Conversation

OleksiiZubko commented Jan 5, 2025 • edited Loading

Description

Checklist

Screenshot OR Video

KiwiKilian commented Jan 5, 2025 • edited Loading

OleksiiZubko commented Jan 5, 2025 • edited Loading

OleksiiZubko commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025 • edited Loading

OleksiiZubko commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025 • edited Loading

OleksiiZubko commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025

OleksiiZubko commented Jan 5, 2025 • edited Loading

KiwiKilian commented Jan 5, 2025

KiwiKilian commented Jan 5, 2025

KiwiKilian left a comment • edited Loading

Choose a reason for hiding this comment

tyrauber commented Jan 6, 2025

KiwiKilian commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

feat: make `setAccessToken(null)` obsolete #593

feat: make `setAccessToken(null)` obsolete #593

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

KiwiKilian commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

KiwiKilian commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

OleksiiZubko commented Jan 5, 2025 •

edited

Loading

KiwiKilian left a comment •

edited

Loading