Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout-minutes to windows-ci workflow #3149

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add timeout-minutes to windows-ci workflow #3149

merged 1 commit into from
Jan 16, 2025

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Jan 16, 2025

This workflow step gets stuck for 6 hours right now. https://github.com/maplibre/maplibre-native/actions/runs/12811603515/job/35721558246

Add a timeout so it will time out quicker.

@louwers louwers requested a review from tdcosta100 January 16, 2025 21:16
@louwers louwers added github_actions Pull requests that update GitHub Actions code windows labels Jan 16, 2025
@louwers louwers enabled auto-merge (squash) January 16, 2025 21:16
cgalvan
cgalvan approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@cgalvan cgalvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we know what makes it timeout intermittently?

@louwers louwers merged commit 42490d5 into maplibre:main Jan 16, 2025
26 of 33 checks passed
@louwers louwers deleted the windows-ci-timeout branch January 16, 2025 23:54
@tdcosta100
Copy link
Collaborator

Nice! Do we know what makes it timeout intermittently?

The timeout usually comes from the vcpkg step, unfortunately it has a bunch of problems in the last updates, so we have to wait some fixes from this component until this problem is gone. This workaround is a good way to deal with this problem meanwhile.

@tdcosta100
Copy link
Collaborator

Hmmm 5 minutes is not enough to vcpkg if it's going to build the packages. Maybe increasing it to 45 minutes is better, maybe 60 if it's not enough for EGL build (building ANGLE is time-consuming).

@yousifd yousifd mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgalvan cgalvan cgalvan approved these changes

@tdcosta100 tdcosta100 Awaiting requested review from tdcosta100

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louwers @tdcosta100 @cgalvan