Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler test failure #3145

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TimSylvester
Copy link
Collaborator

@TimSylvester TimSylvester commented Jan 15, 2025

Add a failing unit test to catch a rare case where Scheduler::GetSequenced cycles through the available items faster than expected, causing the test to fail. Then simplify that method to fix the problem.

@TimSylvester TimSylvester added the bug Something isn't working label Jan 15, 2025
@TimSylvester TimSylvester self-assigned this Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -288  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3145-compared-to-main.txt

Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -704  -0.0%    -360    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3145-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.1Mi  +438% +26.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3145-compared-to-legacy.txt

Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0095         +0.0097             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3145-compared-to-main.txt

@TimSylvester TimSylvester changed the title update test to reproduce problem Fix scheduler test failure Jan 16, 2025
@TimSylvester TimSylvester marked this pull request as ready for review January 16, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant