Replace macro with run-time string concatenation

[alexcristici]

Follow-up on #3089.

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3124-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.1Mi  +438% +26.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3124-compared-to-legacy.txt

[github-actions]

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0194         +0.0190             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3124-compared-to-main.txt

[louwers]

Nice, thanks! I contacted the author of the code snippet. I'll update the PR with the license.

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.2% -32.0Ki  -0.2% -32.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3124-compared-to-main.txt

[louwers]

Bloaty results came back. Seems like it's not optimizing out the unused strings. So this is probably not worth it after all unless we find another approach. What do you think?

[alexcristici]

Bloaty results came back. Seems like it's not optimizing out the unused strings. So this is probably not worth it after all unless we find another approach. What do you think?

That's a big increase in size. I will try to concatenate them in the cpp, maybe this will help?

[louwers]

Interesting, so now it's a size reduction.

[louwers]

Now the concatenation happens at runtime. Probably minimal performance impact?

[alexcristici]

Now the concatenation happens at runtime. Probably minimal performance impact?

Yes, no noticeable differences.