Update SpeedLimitView to the new design
#3809
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jill-cardamon
added
the
UI
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
MaximAlien
reviewed
May 26, 2022
| @@ -227,7 +227,7 @@ | |||
| "ROUTE_QUALITY_ROADS_TOO_NARROW_FEEDBACK" = "Route had roads too narrow to pass"; | |||
|
|
|||
| /* Label above the speed limit in an MUTCD-style speed limit sign. Keep as short as possible. */ | |||
| "SPEED_LIMIT_LEGEND" = "Max"; | |||
| "SPEED_LIMIT_LEGEND" = "Speed Limit"; | |||
There was a problem hiding this comment.
Is Android following similar approach? If so, do they localize this string to other languages as well? Can we re-use them?
| @@ -134,8 +136,13 @@ public class SpeedLimitView: UIView { | |||
|
|
|||
| switch signStandard { | |||
There was a problem hiding this comment.
Will you cover in scope of current PR drawing current speed as well?
ShanMa1991
reviewed
May 26, 2022
| @@ -91,6 +91,82 @@ public class SpeedLimitStyleKit : NSObject { | |||
|
|
|||
| } | |||
|
|
|||
| @objc dynamic public class func drawMUTCDForUS(frame targetFrame: CGRect = CGRect(x: 0, y: 0, width: 68, height: 85), resizing: ResizingBehavior = .aspectFit, signBackColor: UIColor = UIColor(red: 1.000, green: 1.000, blue: 1.000, alpha: 1.000), strokeColor: UIColor = UIColor(red: 0.000, green: 0.000, blue: 0.000, alpha: 1.000), limit: String = "50", legend: String = "SPEED LIMIT") { | |||
There was a problem hiding this comment.
It seems to have issue with the frame size in CarPlay in active navigation. It would lead to the loss of the CompassView and the SpeedLimitView. And I think we should make the width of the SpeedLimitView as same as the CompassView in visualization on CarPlay with the new design.
jill-cardamon
force-pushed
the
jill/speedLimitViewRedesign-currentSpeed
branch
from
52d360e to
2ff373e
Compare
added 2 commits
August 8, 2022 11:38
Breaking Changes in MapboxNavigationBreaking API Changes
|
Breaking Changes in MapboxNavigationBreaking API Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to implement the
SpeedLimitViewredesign.Implementation
Screenshots or Gifs