Add localization for UI strings in Japanese #11704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
added
the
skip changelog
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
YoshiYazawa
reviewed
Apr 11, 2022
|
So far, all of Yoshi-san's review are good and no more comment. But, will we be able to check screenshot for this UI? Are these strings will be fit into one line? (Sometime double bite character / sentences are longer than English one.) If we will have more context, we will be able to provide better one. |
Co-authored-by: Yoshi Yazawa <[email protected]>
|
Hey @YoshiYazawa and @naomism 👋 Thanks for your contribution! I've created a list of screenshots to add more context here #11733 |
YoshiYazawa
approved these changes
Apr 14, 2022
| "AttributionControl.MapFeedback": "マップフィードバック", | ||
| "FullscreenControl.Enter": "フルスクリーンに入る", | ||
| "FullscreenControl.Exit": "全画面表示を終了", | ||
| "GeolocateControl.FindMyLocation": "私の場所を探す", |
There was a problem hiding this comment.
Suggested change
| "GeolocateControl.FindMyLocation": "私の場所を探す", | |
| "GeolocateControl.FindMyLocation": "現在地取得", |
| "FullscreenControl.Enter": "フルスクリーンに入る", | ||
| "FullscreenControl.Exit": "全画面表示を終了", | ||
| "GeolocateControl.FindMyLocation": "私の場所を探す", | ||
| "GeolocateControl.LocationNotAvailable": "場所は利用できません", |
There was a problem hiding this comment.
Suggested change
| "GeolocateControl.LocationNotAvailable": "場所は利用できません", | |
| "GeolocateControl.LocationNotAvailable": "現在地を特定できません", |
| "FullscreenControl.Exit": "全画面表示を終了", | ||
| "GeolocateControl.FindMyLocation": "私の場所を探す", | ||
| "GeolocateControl.LocationNotAvailable": "場所は利用できません", | ||
| "LogoControl.Title": "Mapboxのロゴ", |
There was a problem hiding this comment.
Suggested change
| "LogoControl.Title": "Mapboxのロゴ", | |
| "LogoControl.Title": "Mapbox ロゴ", |
| "Map.Title": "地図", | ||
| "NavigationControl.ResetBearing": "ベアリングを北にリセット", | ||
| "NavigationControl.ZoomIn": "ズームイン", | ||
| "NavigationControl.ZoomOut": "ズームアウトする", |
There was a problem hiding this comment.
Suggested change
| "NavigationControl.ZoomOut": "ズームアウトする", | |
| "NavigationControl.ZoomOut": "ズームアウト", |
| "ScaleControl.Feet": "フィート", | ||
| "ScaleControl.Meters": "m", | ||
| "ScaleControl.Kilometers": "km", | ||
| "ScaleControl.Miles": "自分", |
There was a problem hiding this comment.
Suggested change
| "ScaleControl.Miles": "自分", | |
| "ScaleControl.Miles": "マイル", |
| "ScaleControl.Meters": "m", | ||
| "ScaleControl.Kilometers": "km", | ||
| "ScaleControl.Miles": "自分", | ||
| "ScaleControl.NauticalMiles": "nm", |
There was a problem hiding this comment.
Suggested change
| "ScaleControl.NauticalMiles": "nm", | |
| "ScaleControl.NauticalMiles": "海里", |
| "ScaleControl.Kilometers": "km", | ||
| "ScaleControl.Miles": "自分", | ||
| "ScaleControl.NauticalMiles": "nm", | ||
| "ScrollZoomBlocker.CtrlMessage": "Ctrlキーを押しながらスクロールして地図をズームします", |
There was a problem hiding this comment.
Suggested change
| "ScrollZoomBlocker.CtrlMessage": "Ctrlキーを押しながらスクロールして地図をズームします", | |
| "ScrollZoomBlocker.CtrlMessage": "Ctrl+スクロールを使用して地図をズームします", |
| "ScaleControl.NauticalMiles": "nm", | ||
| "ScrollZoomBlocker.CtrlMessage": "Ctrlキーを押しながらスクロールして地図をズームします", | ||
| "ScrollZoomBlocker.CmdMessage": "⌘+スクロールを使用して地図をズームします", | ||
| "TouchPanBlocker.Message": "2本の指で地図を移動します" |
There was a problem hiding this comment.
Suggested change
| "TouchPanBlocker.Message": "2本の指で地図を移動します" | |
| "TouchPanBlocker.Message": "2本指で地図をスクロールします" |
stepankuzmin
added a commit
that referenced
this pull request
May 20, 2022
* Add localization for UI strings in Japanese * Apply suggestions from code review Co-authored-by: Yoshi Yazawa <[email protected]> Co-authored-by: Yoshi Yazawa <[email protected]>
stepankuzmin
added a commit
that referenced
this pull request
May 24, 2022
* Add localization for UI strings in Japanese * Apply suggestions from code review Co-authored-by: Yoshi Yazawa <[email protected]> Co-authored-by: Yoshi Yazawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR adds translations for UI strings we use in GL JS into Japanese. We translated the UI strings automatically using the Google Translate API, and we need to verify that the translation is correct.
To help us verify the translations, you can open the
Files changedtab on this page and compare the translations with the original filesrc/ui/default_locale.js.If the translation looks good, you can approve it using the
Review changesbutton in theFiles changedtab and selecting theApproveradio button when submitting the review.To improve the machine translation, you can click the plus sign next to the line you want to enhance and select the suggestion button on the toolbar.
After making the suggestions, you can mark the review as finished using the
Review changesbutton and selecting theRequest changesradio button.Thanks for helping 🙌