fix: Fix incorrect structured logging by default (#39)

maou-shonen · Nov 3, 2024 · 7c77de8 · 7c77de8
1 parent b383c96
commit 7c77de8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/middleware.test.ts b/src/middleware.test.ts
@@ -104,6 +104,16 @@ describe("middleware", () => {
       expect(logs[0]).toMatchObject(defaultResLog);
     });
 
+    it("can be JSON serialize", async () => {
+      const { app } = createMockApp();
+
+      const res = await app.request("/");
+      expect(res.status).toBe(200);
+      expect(await res.text()).toBe("ok");
+      expect(logs).toHaveLength(1);
+      expect(() => JSON.stringify(logs[0])).not.toThrow();
+    });
+
     it("with requestId middleware", async () => {
       const app = new Hono()
         .use(

diff --git a/src/middleware.ts b/src/middleware.ts
@@ -92,5 +92,5 @@ export const pinoLogger = <ContextKey extends string = "logger">(
  */
 export const logger = pinoLogger;
 
-let defaultReqId = 0n;
-const defaultReqIdGenerator = () => (defaultReqId += 1n);
+let defaultReqId = 0;
+const defaultReqIdGenerator = () => (defaultReqId += 1);