Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sleep in test algorithm #38689

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

jclarkeSTFC
Copy link
Contributor

This test fails intermittently, but I can't reproduce it, even when building with the CI cmake configuration and running the test 100 times. My best guess is that when the test asserts that the algorithm hasn't finished yet, e.g. here, it was so quick that it has finished, so I've increased the sleep in the test algorithm from 1 ms to 10 ms to make it take longer (but still not long).

If the test continues to fail randomly after this then we can go back to #37760

Fixes #37760.

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

This test fails intermittently, but I can't reproduce it, even when
building with the CI cmake configuration and running the test 100
times. My best guess is that when the test asserts that the
algorithm hasn't finished yet, it was so quick that it has
finished, so I've increased the sleep in the test algorithm to
make it take longer.
@jclarkeSTFC jclarkeSTFC added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Jan 24, 2025
@jclarkeSTFC jclarkeSTFC added this to the Release 6.13 milestone Jan 24, 2025
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review January 24, 2025 11:33
@thomashampson thomashampson self-assigned this Jan 30, 2025
@thomashampson
Copy link
Contributor

Let's get this in and keep an eye on the unit test monitor to see if it has made a difference:
https://mantidproject.github.io/unittest-monitor/Linux_table.html

Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 10 ms is not long at all relative to how long other tests take right?
Maybe you could have made it even longer, but it's difficult to know if you can't reproduce it, so lets see how we get on!

@thomashampson thomashampson merged commit df64c95 into main Jan 30, 2025
10 checks passed
@thomashampson thomashampson deleted the 37760_intermittent_test_fail branch January 30, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate APITest_AsynchronousTest
3 participants