Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods from NeXusFile #38688

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rosswhitfield
Copy link
Member

Description of work

Title.

There may be more but this should be most of them.

Summary of work

Work towards #38332

Further detail of work

To test:

If it compiles and tests pass we should be good.

This does not require release notes because it's an internal change only


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@rosswhitfield rosswhitfield force-pushed the remove_unused_NeXusFile_methods branch from 9e08ad0 to bafec8d Compare January 24, 2025 04:00
@rosswhitfield rosswhitfield added this to the Release 6.13 milestone Jan 24, 2025
@rosswhitfield rosswhitfield added ORNL Team Issues and pull requests managed by the ORNL development team Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly labels Jan 24, 2025
@rosswhitfield rosswhitfield marked this pull request as ready for review January 24, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ORNL Team Issues and pull requests managed by the ORNL development team Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant