fix extractions and improve language_strings_missed contents #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-tz
force-pushed
the
update-result-json
branch
from
9c8e9e6 to
c80c0a4
Compare
mr-tz
commented
Nov 11, 2023
Comment on lines
+143
to
+144
| if not re.sub(r"[\r\n\t]", "", decoded_string).isprintable(): | ||
| raise ValueError("not printable") |
There was a problem hiding this comment.
we've had something similar before and removed it, during my testing this was helpful though
mr-tz
force-pushed
the
update-result-json
branch
from
9b31f45 to
7ff4a51
Compare
mr-tz
force-pushed
the
update-result-json
branch
from
7ff4a51 to
801559a
Compare
Arker123
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes including to update
language_strings_missedto only include strings from the range (e.g..rdatasection for Rust or the strings blob in Go) that may have been missed during extraction.This renders language strings separately from static strings. Language strings are part of static strings and it's currently not possible to display them individually. This can be added later, if desired.
closes #875
closes #900