Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet-6 metapackage #812

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add dotnet-6 metapackage #812

merged 1 commit into from
Feb 6, 2024

Conversation

naacbin
Copy link
Collaborator

@naacbin naacbin commented Dec 24, 2023

I have created this metapackage to address #778 request.
I tried to add the dotnet-6.0-sdk for sfextract. However, when I install this package it doesn't really install the SDK on my system I had to use dotnet-6.0-sdk-4xx. Even, with this package in place when trying to install sfextract I have the following error message :

C:\Users\User\AppData\Local\ChocoCache\6eac32f8-677f-4cec-9471-67015f93f927\restore.csproj : error NU1100: Unable to resolve 'sfextract (>= 2.1.0)' for 'net6.0'.
C:\Users\User\AppData\Local\ChocoCache\6eac32f8-677f-4cec-9471-67015f93f927\restore.csproj : error NU1100: Unable to resolve 'sfextract (>= 2.1.0)' for 'net6.0/any'.

@Ana06
Copy link
Member

Ana06 commented Jan 2, 2024

@naacbin

I tried to add the dotnet-6.0-sdk for sfextract. However, when I install this package it doesn't really install the SDK on my system I had to use dotnet-6.0-sdk-4xx. Even, with this package in place when trying to install sfextract I have the following error message

This is strange, because it is installing correctly in the daily run Have you tried to install it in an empty system? It could be a dependency incompatibility issue, which is exactly what we want to avoid with the metapackages (as all packages request the same version).

Does sfextract work if we only install the desktopruntime (instead of the sdk)?

Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @naacbin!

We should change the package/s that use dotnet directly to use the the metapackage in this PR requiring the new common version.

<dependencies>
<dependency id="common.vm" />
<dependency id="dotnet-6.0-desktopruntime" version="[6.0.25]" />
<dependency id="dotnet-6.0-runtime" version="[6.0.25]" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .NET Desktop Runtime includes the .NET Runtime, so that the second dependency shouldn't be needed. 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I have tried with only dotnet-6.0-desktopruntime and CLI application can't run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which CLI application?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naacbin which CLI applications does not run without dotnet-6.0-runtime?

@naacbin
Copy link
Collaborator Author

naacbin commented Jan 3, 2024

@naacbin

I tried to add the dotnet-6.0-sdk for sfextract. However, when I install this package it doesn't really install the SDK on my system I had to use dotnet-6.0-sdk-4xx. Even, with this package in place when trying to install sfextract I have the following error message

This is strange, because it is installing correctly in the daily run Have you tried to install it in an empty system? It could be a dependency incompatibility issue, which is exactly what we want to avoid with the metapackages (as all packages request the same version).

Does sfextract work if we only install the desktopruntime (instead of the sdk)?

No, the install doesn't work with only "desktopruntime" too. I will test on an empty system in the next week (if I find time to do it).

@naacbin
Copy link
Collaborator Author

naacbin commented Jan 8, 2024

I don't know why it didn't worked on my previous machine but now I can install sfextract. However, I don't think SDK dependency should be added to this package as it requires a lot of space (800Mb) and is only used by sfextract. This could be reconsidered if other packages in the future use the SDK.

If it's good on your side, we could merge this one and I will update #778

@naacbin naacbin mentioned this pull request Jan 8, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naacbin can you add using this dependency in arsenalimagemounter.vm to this PR? If sfextract works with this dependency instead of the actual sdk please update it too.

packages/dotnet-6.vm/dotnet-6.vm.nuspec Outdated Show resolved Hide resolved
@naacbin
Copy link
Collaborator Author

naacbin commented Jan 10, 2024

@naacbin can you add using this dependency in arsenalimagemounter.vm to this PR? If sfextract works with this dependency instead of the actual sdk please update it too.

  • For arsenalimagemounter.vm, I used a metapackage that already require this dependency. Should I remove it from the package or replace it with the one of this PR ?
  • sfextract doesn't work with this package, only the SDK.

@Ana06
Copy link
Member

Ana06 commented Jan 12, 2024

For arsenalimagemounter.vm, I used a metapackage that already require this dependency. Should I remove it from the package or replace it with the one of this PR ?

I propose to add both the dependency for the metapackage and this dependency (as they are compatible). Otherwise, arsenalimagemounter could install a newer version of .NET and we will end with two version of .NET package, which may cause conflicts.

We have had problems in the test suite when different packages installed different versions of the same dependency. We are trying to figure out the best way to avoid this to happen, so @naacbin if you have ideas how to improve this, please let us know. 😉

@naacbin naacbin force-pushed the dotnet-6 branch 5 times, most recently from dd6886b to 4c84d6d Compare January 13, 2024 10:05
@naacbin
Copy link
Collaborator Author

naacbin commented Jan 23, 2024

For arsenalimagemounter.vm, I used a metapackage that already require this dependency. Should I remove it from the package or replace it with the one of this PR ?

I propose to add both the dependency for the metapackage and this dependency (as they are compatible). Otherwise, arsenalimagemounter could install a newer version of .NET and we will end with two version of .NET package, which may cause conflicts.

We have had problems in the test suite when different packages installed different versions of the same dependency. We are trying to figure out the best way to avoid this to happen, so @naacbin if you have ideas how to improve this, please let us know. 😉

I remove the commit to change arsenalimagemounter as it will be handle in a different PR to support dotnet-8 #852.
This PR can be merged.

@naacbin naacbin requested a review from Ana06 January 30, 2024 19:45
@naacbin naacbin merged commit 6d6a15a into mandiant:main Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants