-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotnet-6 metapackage #812
Conversation
This is strange, because it is installing correctly in the daily run Have you tried to install it in an empty system? It could be a dependency incompatibility issue, which is exactly what we want to avoid with the metapackages (as all packages request the same version). Does sfextract work if we only install the desktopruntime (instead of the sdk)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @naacbin!
We should change the package/s that use dotnet directly to use the the metapackage in this PR requiring the new common version.
<dependencies> | ||
<dependency id="common.vm" /> | ||
<dependency id="dotnet-6.0-desktopruntime" version="[6.0.25]" /> | ||
<dependency id="dotnet-6.0-runtime" version="[6.0.25]" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think .NET Desktop Runtime includes the .NET Runtime, so that the second dependency shouldn't be needed. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, I have tried with only dotnet-6.0-desktopruntime
and CLI application can't run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which CLI application?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naacbin which CLI applications does not run without dotnet-6.0-runtime
?
No, the install doesn't work with only "desktopruntime" too. I will test on an empty system in the next week (if I find time to do it). |
I don't know why it didn't worked on my previous machine but now I can install If it's good on your side, we could merge this one and I will update #778 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naacbin can you add using this dependency in arsenalimagemounter.vm to this PR? If sfextract works with this dependency instead of the actual sdk please update it too.
|
I propose to add both the dependency for the metapackage and this dependency (as they are compatible). Otherwise, arsenalimagemounter could install a newer version of .NET and we will end with two version of .NET package, which may cause conflicts. We have had problems in the test suite when different packages installed different versions of the same dependency. We are trying to figure out the best way to avoid this to happen, so @naacbin if you have ideas how to improve this, please let us know. 😉 |
dd6886b
to
4c84d6d
Compare
I remove the commit to change |
I have created this metapackage to address #778 request.
I tried to add the
dotnet-6.0-sdk
for sfextract. However, when I install this package it doesn't really install the SDK on my system I had to usedotnet-6.0-sdk-4xx
. Even, with this package in place when trying to install sfextract I have the following error message :