-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue where the Groupable did not properly support AutoWidth and AutoHeight #34
base: master
Are you sure you want to change the base?
Conversation
Hi, Can you add your ViewController as a test case - CardViewControllerDemo? Something like that. Thanks |
As soon as I can I take a look at the details and update you, but on first glance I noticed how different the style/format is from the rest of the project. I'd like to keep everything consistent, i.e. parens around math to make order of operations clear to readers, declaring |
Sorry for the slow response. My wife and I were welcoming our firstborn child into the world and everything else took the back burner... @mamaral, I tried to match the style as best I could. Let me know if you'd like anything else changed. @tim12s, I included an example of how one might create cards using only this library. And for a bit of fun: |
@dulbrich Congrats!! I've been quite busy as well, so I'll take a look at this once more as soon as I get a chance but the style fixes look perfect. |
@dulbrich A bunch has changed in the last couple of months - if you can resolve the conflicts I'll get it merged. |
Useful when making cards and you don't know how tall the text in the middle is going to be.