-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema manager #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pounard
force-pushed
the
no-issue-schema-manager
branch
13 times, most recently
from
March 1, 2024 11:44
fda8210
to
448576f
Compare
Lonnytunes
reviewed
Mar 1, 2024
pounard
force-pushed
the
no-issue-schema-manager
branch
2 times, most recently
from
March 1, 2024 16:24
e40707d
to
239d12e
Compare
pounard
force-pushed
the
no-issue-schema-manager
branch
2 times, most recently
from
March 12, 2024 14:37
63050b0
to
6b18ade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API seems really nice to use!
congrats!
…herwise we break the server limit
pounard
force-pushed
the
no-issue-schema-manager
branch
from
March 12, 2024 15:14
1379348
to
dabaa68
Compare
pounard
force-pushed
the
no-issue-schema-manager
branch
from
March 12, 2024 16:18
9b48890
to
784f890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan
What's working
What's missing
Allow arbitrary SQL queries during schema transaction, lets sayDone it !->query(fn (QueryBuilder): void)
, which does not directly executes the SQL but stacks it into the change log (after all, schema transactions are basically upgrade procedures, and the user probably wants to be able to add data alteration along the way)ALTER TABLE x MODIFY COLUMN yOK done it!Future plans