Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline data for product primitive examples #478

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

jamesqquick
Copy link
Contributor

  • inline data in <Products-Carousel> and <Products-List> components
  • shorten example names to remove -example
  • add separate examples for <Products-Carousel> to show differentiated data
  • removed loader examples and added loading skeletons/streaming into primary example

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 5:12pm

migueloller
migueloller previously approved these changes Feb 4, 2025
Copy link
Member

@migueloller migueloller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

One minor thing I noticed is that we're re-defining the Product type on each example and I was thinking we might be able to reuse the ones from the sections

@jamesqquick jamesqquick force-pushed the inline-data-product-primitives branch from 27b8e13 to 57af858 Compare February 4, 2025 23:25
@github-actions github-actions bot dismissed migueloller’s stale review February 4, 2025 23:25

Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/makeswift/vibes/actions/runs/13146795470

@jamesqquick jamesqquick enabled auto-merge (rebase) February 5, 2025 17:04
@jamesqquick jamesqquick force-pushed the inline-data-product-primitives branch from e1cc1a9 to 0235f7d Compare February 5, 2025 17:05
@jamesqquick jamesqquick merged commit db487aa into main Feb 5, 2025
4 checks passed
@jamesqquick jamesqquick deleted the inline-data-product-primitives branch February 5, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants