-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline data for product primitive examples #478
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻
One minor thing I noticed is that we're re-defining the Product
type on each example and I was thinking we might be able to reuse the ones from the sections
apps/web/vibes/soul/examples/primitives/products-carousel/electric.tsx
Outdated
Show resolved
Hide resolved
27b8e13
to
57af858
Compare
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff
at https://github.com/makeswift/vibes/actions/runs/13146795470
e1cc1a9
to
0235f7d
Compare
<Products-Carousel>
and<Products-List>
components-example
<Products-Carousel>
to show differentiated data