Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Update domains client to use v4 of API #434

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

olexandr-mazepa
Copy link
Collaborator

@olexandr-mazepa olexandr-mazepa commented Jan 7, 2025

closes #429

This PR includes the following changes:

  • Removed DomainShortData type, because there is no difference between DomainShortData and DomainData in the new version.
  • created_at is now a Date object instead of a string in the TDomain type.
  • The query type for the domains.list method was extended by state, sort, authority, and search properties.
  • The domains.get method was extended, and now allows query.
  • Fixed getConnection method to return data instead of undefined.
  • getIps, assignIp, deleteIp, linkIpPool, unlinkIpPoll, and updateWebPrefix methods in the DomainClient have been deprecated.
  • domains.updateDKIMSelector response shape is changed from { body: { message: 'DKIM selector changed' }, status: 200 } to {message: 'DKIM selector changed', status: 200 }

@olexandr-mazepa olexandr-mazepa changed the title breaking: Update domains client to use v4 of API WIP breaking: Update domains client to use v4 of API Jan 7, 2025
@olexandr-mazepa olexandr-mazepa changed the title WIP breaking: Update domains client to use v4 of API breaking: Update domains client to use v4 of API Jan 8, 2025
@olexandr-mazepa olexandr-mazepa merged commit 009065a into master Jan 9, 2025
4 checks passed
@olexandr-mazepa olexandr-mazepa deleted the update-domains-type branch January 9, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Type
1 participant