This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
[WIP]feat(fbcnms-ui): Add Host Portal Login Page #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
HannaFar
changed the title
HannaFar
force-pushed
the
hostPortalLogin
branch
from
be81e11 to
8e9b382
Compare
HannaFar
force-pushed
the
hostPortalLogin
branch
from
8e9b382 to
8bf968f
Compare
andreilee
suggested changes
Mar 15, 2022
| const params = new URLSearchParams(window.location.search); | ||
| const to = params.get('to'); | ||
|
|
||
| const hostPortal = window.location.hostname.slice(0, 4) === 'mast'; |
| const params = new URLSearchParams(window.location.search); | ||
| const to = params.get('to'); | ||
|
|
||
| const hostPortal = window.location.hostname.slice(0, 4) === 'mast'; |
There was a problem hiding this comment.
While this works, you should really be parsing the entire organization name
ie. in master.nms.com/master, you should check up until the first period.
There could be legitimate organization names that start with 'mast'.
There was a problem hiding this comment.
Sorry this was just to test.
This will be replaced by 'host'
| const params = new URLSearchParams(window.location.search); | ||
| const to = params.get('to'); | ||
|
|
||
| const hostPortal = window.location.hostname.slice(0, 4) === 'mast'; | ||
| const hostname = window.location.hostname; |
There was a problem hiding this comment.
While a decent substitute for the organization name, you'll want to access the proper spelling and capitalization for the organization through @fbcnms/sequelize-models.
Signed-off-by: HannaFar <[email protected]>
HannaFar
force-pushed
the
hostPortalLogin
branch
from
8bf968f to
bc7e5ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: HannaFar [email protected]
Add Host Portal and Organization Portal Login page
Host Portal Login Page :
Organization Portal Login Page :
