Dev rds ssl #392
Draft
Dev rds ssl #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…affic. This commit check if WARMUP is accessible on app nodes with timeout (magento_node_wait_for_warmup_secs)
Order of dependencies in requirements does matter and pip isn't smart enought to choice correct versions when there is conflict Also remove outdated cloudfront override
Current location is not included in nginx configuration therefore it had no effect
For this purpose QA can add ?__mgo_bypass_token=token to URL. This action set MageOpsBypassToken cookie and works utill this cookie will be deleted. When the cookie is set Varnish will deliver content without using cache.
MariuszJozwiak
force-pushed
the
dev-rds-ssl
branch
4 times, most recently
from
3e6694c to
a8d1c91
Compare
MariuszJozwiak
force-pushed
the
dev-rds-ssl
branch
from
a8d1c91 to
17cb5b0
Compare
krisdante
suggested changes
Apr 10, 2024
| scope = "default" | ||
| ON DUPLICATE KEY UPDATE | ||
| value = "{{ magento_db_setting.value | quote }}" | ||
| ca_cert: /tmp/eu-central-1-bundle.pem |
There was a problem hiding this comment.
Please do not store permament files in temp
There was a problem hiding this comment.
Make that confirurable and resonable
| @@ -1,10 +1,17 @@ | |||
| - name: Download CA RDS | |||
There was a problem hiding this comment.
This is downloaded so many times. Why? Cant we just download it once ? Or check if it does not exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.