Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG#PWA-3179 only one folder should be remained open when navigating … #4195

Merged
merged 3 commits into from
Mar 18, 2024
Merged

BUG#PWA-3179 only one folder should be remained open when navigating … #4195

merged 3 commits into from
Mar 18, 2024

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

@RaghavendraTirumalasetti RaghavendraTirumalasetti commented Nov 6, 2023 •
edited
Loading

only one folder should be remained open when navigating the control from profile to minicart or viceversa.

Description

TODO: only one folder should be remained open when navigating the control from profile to minicart or viceversa.

Pre-Conditions:

  1. venia.magento.com for testing the accessibility scope
  2. Controle navigation using tab button instead of mouse
  3. any flow guest or registered user

Steps to Execute:

  1. use tab button button and navigate till login profile
  2. press enter to expend the login folder for username and password
  3. now keep pressing tab untill system control is navigated on mini cart
  4. press Enter button and observe if Mini cart folder is also expnded

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3179.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@RaghavendraTirumalasetti
BUG#PWA-3179 only one folder should be remained open when navigating …
c877ee4 
…the control from profile to minicart or viceversa
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 6, 2023 •
edited
Loading

Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3179.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 8e2ecc4

@RaghavendraTirumalasetti
BUG#PWA-3179 only one folder should be remained open when navigating …
00841cd 
…the control from profile to minicart or viceversa
@glo82145
Copy link
Collaborator

run lighthouse-desktop

4 similar comments
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 18, 2024
@glo82145 glo82145 merged commit b4e0f2a into develop Mar 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo82145 glo82145 glo82145 approved these changes

Assignees

@glo82145 glo82145

Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaghavendraTirumalasetti @pwa-studio-bot @glo82145