-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous Import #330
Open
naydav
wants to merge
2
commits into
magento:master
Choose a base branch
from
naydav:asynchronous-import
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Asynchronous Import #330
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 0 additions & 16 deletions
16
design-documents/asynchronous-import/asycnhronous-import-service.md
This file was deleted.
Oops, something went wrong.
48 changes: 48 additions & 0 deletions
48
design-documents/asynchronous-import/asycnhronous-import.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Asynchronous Import as separate service | ||
|
||
Main idea of extension is to replace current Import module with new implementation that will allow to users import objects in Magento by using Asynchronous approach. | ||
|
||
## Workflow | ||
|
||
- Upload source data to instance storage (optional step); | ||
- Retrieve source data from Source (partial reading); | ||
- Parse source data; | ||
- Apply data converting rule; | ||
- Exchange data with Magento instance via Bulk API Service contracts / Bulk API REST (partial processing); | ||
- Later an user can request balk status of import and resubmit objects which were failed during the import; | ||
|
||
## REST API | ||
|
||
- [REST API](rest-api.md) | ||
|
||
## Modularity (API / Extension points) | ||
|
||
- [Start Import based on CSV data (main entry point)](modularity/import-csv.md) | ||
- [Source data retrieving](modularity/source-data-retrieving.md) | ||
- [Data converting before import](modularity/data-converting.md) | ||
- [Data exchanging with Magento instance](modularity/data-exchanging.md) | ||
- [Import advanced pricing](modularity/advanced-pricing.md) | ||
|
||
## MVP | ||
|
||
[MVP Board](https://app.zenhub.com/workspaces/async-import-5b5f349bd6768d6255917727/reports/burndown?milestoneId=4625823) | ||
|
||
- Sources data retrieving: *HTTP, HTTPS, base64*; | ||
- CSV reader; | ||
- Data Converting Rules; | ||
- Import Data Exchanging; | ||
- Import Configuration; | ||
- Product import; | ||
- Stock import; | ||
- Advanced pricing import; | ||
- Documentation; | ||
|
||
## UML | ||
|
||
![AsyncImportUML@2x](AsyncImportUML.png) | ||
|
||
## TODO | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets change a Priorities here
|
||
- Design of Import configuration; | ||
- Design of Get Import status; | ||
- Design of Import processing - Sync / Async | ||
- Design of Restart failed operations |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1- It will be helpful to add a diagram to show the flow of interaction between the modules!
2- A simple class / interface UML diagram will make it really easy to grasp the concepts