This repository has been archived by the owner on Apr 29, 2019. It is now read-only.
Added notes and tooltip to import behavior field in import form #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ort-improvements into 89-behavior-tooltips
dmanners
reviewed
Nov 23, 2018
app/code/Magento/ImportExport/Block/Adminhtml/Import/Edit/Form.php
Outdated
Show resolved
Hide resolved
…ort-improvements into 89-behavior-tooltips
…ort-improvements into 89-behavior-tooltips
dmanners
previously approved these changes
Nov 26, 2018
lorikrell
previously approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Hi @federivo your work is great! :)
I provided suggested edits. These are clean up edits, they don't change the meaning of the content. I recommend accepting them, but don't require them for the PR. I will be updating the merchant docs with edits for 2.3! Thanks!
If you made changes to the fields/affected the UI, please let me know. I can update the docs for these changes in a future release.
Co-Authored-By: federivo <[email protected]>
Co-Authored-By: federivo <[email protected]>
Co-Authored-By: federivo <[email protected]>
|
Hey @lorikrell, I just accepted your changes. Let me know if you need me to change anything else. Thanks!!! |
|
@federivo You are awesome! Thanks for adding those in. :D |
lorikrell
approved these changes
Nov 26, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added notes and tooltip to the Import Behavior field in the import form in the admin. This is to improve the information given to the user at the time of running an iimport.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)