Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Xcode 14.3, and update rustc nightly #487

Merged
merged 10 commits into from
Aug 27, 2023
Merged

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Aug 27, 2023

A change in rustc dead code elimination causes the UTF16 in ns_string! to appear in the assembly output; tracking that in #258.

UI tests triage: Have mostly improved, the changed ordering for "help: the following other types implement trait ..." are nice, except for MethodImplementation, that one is still mostly gibberish.
Also, spans inside declare_class! have now been fixed, such that the erring function is reported, which is really nice!

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates A-framework Affects the framework crates and the translator for them labels Aug 27, 2023
@madsmtm madsmtm force-pushed the update-xcode-nightly branch 2 times, most recently from 3ed7d95 to 53bf196 Compare August 27, 2023 20:11
@madsmtm madsmtm force-pushed the update-xcode-nightly branch from 53bf196 to f45c33d Compare August 27, 2023 21:58
@madsmtm madsmtm marked this pull request as ready for review August 27, 2023 21:59
@madsmtm
Copy link
Owner Author

madsmtm commented Aug 27, 2023

@simlay, @samuelsleight: I've updated the Xcode version to 14.3.1, along with running it with a newer clang, so it should be easier for you to contribute after this PR (though you might want to hold off until #345)

@madsmtm madsmtm merged commit b832f25 into master Aug 27, 2023
@madsmtm madsmtm deleted the update-xcode-nightly branch August 27, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Affects the framework crates and the translator for them A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant