Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance variable object encoding with extended type information #454

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jun 3, 2023

Instance variables include extended type information, we should find some way to represent this.

See: https://bou.io/ExtendedTypeInfoInObjC.html

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Jun 3, 2023
@madsmtm
Copy link
Owner Author

madsmtm commented Jun 3, 2023

While fairly easy to parse, I'm yet unsure of how it should be represented in objc2-encode, since we want objc2::encode::Encode::ENCODING to return something that can always be used, regardless of context. So e.g. if we have something with Encoding::Object(None), how should that compare to Encoding::Object(Some("MyClass"))? And what should the Display implementation default to outputting?

@madsmtm madsmtm added this to the Usable icrate milestone Sep 5, 2023
@madsmtm madsmtm force-pushed the fix-ivar-object-encoding branch from e81a5cc to 2d47b81 Compare December 3, 2023 06:55
@madsmtm madsmtm marked this pull request as ready for review December 3, 2023 06:55
@madsmtm
Copy link
Owner Author

madsmtm commented Dec 3, 2023

I'm going to just parse and ignore it for now

@madsmtm madsmtm force-pushed the fix-ivar-object-encoding branch from 2d47b81 to 831716e Compare December 3, 2023 06:57
@madsmtm madsmtm merged commit 810d88e into master Dec 3, 2023
19 checks passed
@madsmtm madsmtm deleted the fix-ivar-object-encoding branch December 3, 2023 07:14
@madsmtm madsmtm changed the title Fix instance variable object encoding Fix instance variable object encoding with extended type information Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant