Remove deprecated "apple" Cargo feature

madsmtm · Jan 15, 2025 · 2125d2c · 2125d2c
1 parent 65fd4a7
commit 2125d2c
Show file tree

Hide file tree

Showing 16 changed files with 6 additions and 29 deletions.
diff --git a/crates/block2/CHANGELOG.md b/crates/block2/CHANGELOG.md
@@ -18,6 +18,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 * **BREAKING**: Converted function signatures into using `extern "C-unwind"`.
   This allows unwinding through blocks.
 
+### Removed
+* **BREAKING**: Removed the deprecated `apple` Cargo feature flag.
+
 
 ## 0.5.1 - 2024-05-21
 

diff --git a/crates/block2/Cargo.toml b/crates/block2/Cargo.toml
@@ -25,9 +25,6 @@ default = ["std"]
 std = ["alloc"]
 alloc = []
 
-# Deprecated; this is the default on Apple platforms, and not applicable on other platforms.
-apple = []
-
 # Link to libBlocksRuntime from compiler-rt.
 compiler-rt = ["objc2/unstable-compiler-rt"] # TODO: fix this
 

diff --git a/crates/header-translator/src/id.rs b/crates/header-translator/src/id.rs
@@ -709,7 +709,7 @@ impl ItemTree {
         .into_iter()
     }
 
-    /// Required Cargo.toml features in [dependencies] table.
+    /// Required Cargo.toml features in `[dependencies]` table.
     ///
     /// Returns (crate, required_feature) pairs.
     pub fn required_crate_features<'config>(
@@ -774,7 +774,7 @@ impl ItemTree {
         crate_features.into_iter()
     }
 
-    /// The Cargo.toml features that will be enabled in [features] table.
+    /// The Cargo.toml features that will be enabled in `[features]` table.
     ///
     /// Returns (feature, enabled_feature) pairs.
     pub fn enabled_features(

diff --git a/crates/objc2-proc-macros/Cargo.toml b/crates/objc2-proc-macros/Cargo.toml
@@ -23,9 +23,6 @@ workspace = true
 [features]
 default = []
 
-# Deprecated; this is the default on Apple platforms, and not applicable on other platforms.
-apple = []
-
 # Runtime selection (for future compatibility)
 gnustep-1-7 = []
 gnustep-1-8 = ["gnustep-1-7"]

diff --git a/crates/objc2/CHANGELOG.md b/crates/objc2/CHANGELOG.md
@@ -199,6 +199,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
   `IdIntoIterator`, as well as their methods. Use the renamed traits instead.
 * **BREAKING**: Removed the ability to implement `ClassType` manually, to make
   it easier to evolve the API going forwards.
+* **BREAKING**: Removed the deprecated `apple` Cargo feature flag.
 
 ### Fixed
 * Remove an incorrect assertion when adding protocols to classes in an unexpected

diff --git a/crates/objc2/Cargo.toml b/crates/objc2/Cargo.toml
@@ -92,9 +92,6 @@ unstable-arbitrary-self-types = []
 # Uses the nightly derive_coerce_pointee feature to make conversions more ergonomic.
 unstable-coerce-pointee = []
 
-# Deprecated; this is the default on Apple platforms, and not applicable on other platforms.
-apple = []
-
 # Compile for GNUStep's libobjc2
 #
 # `unstable-static-class` is always enabled on GNUStep, as it fails to link in

diff --git a/framework-crates/objc2-app-kit/Cargo.modified.toml b/framework-crates/objc2-app-kit/Cargo.modified.toml
@@ -1,7 +1,4 @@
 [features]
-# Deprecated; this is the default on Apple platforms, and not applicable on other platforms.
-apple = []
-
 # Runtime selection. See `objc2` for details.
 gnustep-1-7 = ["objc2/gnustep-1-7", "block2?/gnustep-1-7", "objc2-foundation/gnustep-1-7", "objc2-core-data?/gnustep-1-7", "objc2-quartz-core?/gnustep-1-7"]
 gnustep-1-8 = ["gnustep-1-7", "objc2/gnustep-1-8", "block2?/gnustep-1-8", "objc2-foundation/gnustep-1-8", "objc2-core-data?/gnustep-1-8", "objc2-quartz-core?/gnustep-1-8"]

diff --git a/framework-crates/objc2-app-kit/Cargo.toml b/framework-crates/objc2-app-kit/Cargo.toml
diff --git a/framework-crates/objc2-core-data/Cargo.modified.toml b/framework-crates/objc2-core-data/Cargo.modified.toml
@@ -1,6 +1,4 @@
 [features]
-# No-op, deprecated
-apple = []
 gnustep-1-7 = []
 gnustep-1-8 = []
 gnustep-1-9 = []

diff --git a/framework-crates/objc2-core-data/Cargo.toml b/framework-crates/objc2-core-data/Cargo.toml
diff --git a/framework-crates/objc2-core-image/Cargo.modified.toml b/framework-crates/objc2-core-image/Cargo.modified.toml
@@ -1,7 +1,4 @@
 [features]
-# Deprecated; this is the default on Apple platforms, and not applicable on other platforms.
-apple = []
-
 # Runtime selection. See `objc2` for details.
 gnustep-1-7 = ["objc2/gnustep-1-7", "block2?/gnustep-1-7", "objc2-foundation/gnustep-1-7"]
 gnustep-1-8 = ["gnustep-1-7", "objc2/gnustep-1-8", "block2?/gnustep-1-8", "objc2-foundation/gnustep-1-8"]

diff --git a/framework-crates/objc2-core-image/Cargo.toml b/framework-crates/objc2-core-image/Cargo.toml
diff --git a/framework-crates/objc2-foundation/Cargo.modified.toml b/framework-crates/objc2-foundation/Cargo.modified.toml
@@ -22,9 +22,6 @@ required-features = [
 ]
 
 [features]
-# Deprecated; this is the default on Apple platforms, and not applicable on other platforms.
-apple = []
-
 # Runtime selection. See `objc2` for details.
 gnustep-1-7 = ["objc2/gnustep-1-7", "block2?/gnustep-1-7"]
 gnustep-1-8 = ["gnustep-1-7", "objc2/gnustep-1-8", "block2?/gnustep-1-8"]

diff --git a/framework-crates/objc2-foundation/Cargo.toml b/framework-crates/objc2-foundation/Cargo.toml
diff --git a/framework-crates/objc2-quartz-core/Cargo.modified.toml b/framework-crates/objc2-quartz-core/Cargo.modified.toml
@@ -2,8 +2,6 @@
 description = "Bindings to the QuartzCore/CoreAnimation framework"
 
 [features]
-# No-op, deprecated
-apple = []
 gnustep-1-7 = []
 gnustep-1-8 = []
 gnustep-1-9 = []

diff --git a/framework-crates/objc2-quartz-core/Cargo.toml b/framework-crates/objc2-quartz-core/Cargo.toml