Allow type overrides at the container level #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selection does not work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For types with hand-coded Serialize / Deserialize impls, it can be useful to be able to specify the typescript definition manually. This patch adds a "type" attribute at the container level, similar to the one at field level, and when set produces a type alias for the field instead of the derived struct / enum type.
I am not quite sure if my interpretation of the 'type_params' field is correct, so please verify. Also, we might want to allow free-form declarations (eg. #[tsify(type = "export interface MyType {...}")]) instead restricting the attribute to type aliasses.