Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106 snapshot testing util does not work for dataframes with custom non unique index #112

Conversation

a-mosquito
Copy link
Collaborator

No description provided.

@a-mosquito
Copy link
Collaborator Author

also contains a workaround for #92

@a-mosquito a-mosquito requested a review from AKuederle June 24, 2024 11:07
@AKuederle
Copy link
Member

@a-mosquito Can you resolve the merge conflicts and create an integration branch in mobgap? So basically check if the changes would lead to test failures there?

Other than that, looks great! A lot of pandas magic :D

@a-mosquito a-mosquito force-pushed the 106-snapshot-testing-util-does-not-work-for-dataframes-with-custom-non-unique-index branch from 1c4ae23 to 111b91d Compare June 26, 2024 08:55
@AKuederle
Copy link
Member

Is this ready from your side? @a-mosquito

@AKuederle AKuederle merged commit f72fcf3 into main Jun 28, 2024
3 checks passed
@AKuederle AKuederle deleted the 106-snapshot-testing-util-does-not-work-for-dataframes-with-custom-non-unique-index branch June 28, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot testing util does not work for Dataframes with custom, non-unique index
2 participants