FIxed stupid bug

mad-lab-fau · Jul 26, 2024 · 6e705de · 6e705de
1 parent 12a9b5e
commit 6e705de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/test_pipelines/test_scorer.py b/tests/test_pipelines/test_scorer.py
@@ -239,7 +239,7 @@ def test_default_agg_method(self, mock_aggregate, scorer_return):
         _ = scorer(pipe, data)
 
         expected_called = (
-            len([s for s in scorer_return.values() if not isinstance(s, type(no_agg))])
+            len([s for s in scorer_return.values() if not isinstance(s, type(no_agg(None)))])
             if isinstance(scorer_return, dict)
             else 1
         )

diff --git a/tpcp/validate/_scorer.py b/tpcp/validate/_scorer.py
@@ -420,7 +420,7 @@ def _test_single_score_value(scores: list[any], default_agg: Aggregator):
         raise _non_homogeneous_scoring_error
     if not isinstance(scores[0], Aggregator):
         # If the score is not wrapped in an aggregator, we wrap it in the default aggregator.
-        scores = [default_agg.clone()(s) for s in scores]
+        scores = [default_agg(s) for s in scores]
     scores[0]._assert_is_all_valid(scores, "single score")
     return (
         scores[0].clone(),