change motor parameter to match what's shipped in the Filastruder kit #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if the goal is to support exactly what's in the Filastruder kit, but, the stepping angle doesn't match what's in the config.g file. If there's a different machine build that this is supposed to target, please ignore this PR, but maybe it would be helpful to have a README or something like that somewhere which notes the deviation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if the goal is to support exactly the LDO motors that are shipped in the Filastruder kit, but, after building the kit it seems the stepping angle of the provided motor doesn't match what's in the config.g file. This changes the angle from 1.8 to 0.9 degrees, and this seems to make homing happy.
If there's a different machine build that this is supposed to target, please ignore this PR, but maybe it would be helpful to have a README or something like that somewhere which notes the deviation?