Fix plugin numbering when adding plugins #2201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsujan
requested changes
Dec 21, 2024
tsujan
reviewed
Dec 21, 2024
| @@ -284,7 +284,9 @@ QPointer<Plugin> PanelPluginsModel::loadPlugin(LXQt::PluginInfo const & desktopF | |||
|
|
|||
| QString PanelPluginsModel::findNewPluginSettingsGroup(const QString &pluginType) const | |||
| { | |||
| QStringList groups = mPanel->settings()->childGroups(); | |||
| QString userConfigDir = QStandardPaths::writableLocation(QStandardPaths::ConfigLocation); | |||
| QSettings userSettings(QStringLiteral("%1/lxqt/panel.conf").arg(userConfigDir), QSettings::IniFormat); | |||
There was a problem hiding this comment.
There isn't a reason that the config file should be panel.conf, to say nothing of its path. The panel config file I'm using right now is panel-kwin_wayland.conf.
#2126 was rather a question, whose answer you found. It was by no means a bug, and can be closed.
There was a problem hiding this comment.
I'll close this PR because I'm not very familiar with Qt's system integration, nor LXQt settings.
I think it is a bug to have "<pluginname>2" as the first numbering, due to system config, though.
There was a problem hiding this comment.
I think it is a bug…
By definition, it isn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2126