Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bashisms in lxqt-transupdate for better portability with non-bash #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sfalken
Copy link

@sfalken sfalken commented Mar 2, 2023

Changes to fix "bashims" in lxqt-transupdate, for better portability with non-bash compliant shells.

@stefonarch
Copy link
Member

Typo?

$ /tmp/transupdate 
/tmp/transupdate: line 39: print: command not found
== Template Update ==lupdate ./pcmanfm -ts ./pcmanfm/translations/pcmanfm-qt.ts -locations absolute -no-obsolete
Scanning directory './pcmanfm'...
Updating 'pcmanfm/translations/pcmanfm-qt.ts'...
    Found 452 source text(s) (0 new and 452 already existing)

@sfalken
Copy link
Author

sfalken commented Mar 2, 2023

Ah, yes, that is a typo. facepalm
You prefer a revoke and re submit?

@stefonarch
Copy link
Member

You can just correct it and push it again, no?

@sfalken
Copy link
Author

sfalken commented Mar 2, 2023

Probably, I feel like I have to re-teach myself git/github a little everytime I use it.

@sfalken
Copy link
Author

sfalken commented Mar 2, 2023

I think that should do it.

@stefonarch
Copy link
Member

LGTM

@stefonarch
Copy link
Member

Just noticed this is still open, any objection merging it?

@redtide redtide mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants