Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with LDF 1.0.0 #233

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Jan 23, 2025

  • Fixed an error in luxonis_ml data info command when used with dataset created using LDF v1.0.0
  • Improved the migration so it works with luxonis-train as well

@kozlov721 kozlov721 requested a review from a team as a code owner January 23, 2025 16:58
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team January 23, 2025 16:58
@github-actions github-actions bot added fix Fixing a bug data Changes affecting luxonis_ml.data subpackage CLI Changes affecting the CLI labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (a04af9a) to head (3017ec2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #233       +/-   ##
=========================================
+ Coverage      0   95.79%   +95.79%     
=========================================
  Files         0       90       +90     
  Lines         0     4785     +4785     
=========================================
+ Hits          0     4584     +4584     
- Misses        0      201      +201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozlov721 kozlov721 force-pushed the fix/ldf-0.0.1-compatibility branch from a89713a to 3017ec2 Compare January 24, 2025 02:41
@kozlov721 kozlov721 merged commit a770f26 into main Jan 24, 2025
12 checks passed
@kozlov721 kozlov721 deleted the fix/ldf-0.0.1-compatibility branch January 24, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Changes affecting the CLI data Changes affecting luxonis_ml.data subpackage fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants