new luv_cleanup to handle cleanup of non-gc resources #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a solution to the problem of cleaning up luv resources when using an external uv_loop_t in cases such as neovim. This function is necessary for external loops to not leak memory when luv is no longer in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a solution to the problem of cleaning up luv resources when using an external uv_loop_t in cases such as neovim introduced by moving work cleanup into the
__gcfor the loop.This function is necessary for external loops to not leak memory when luv is no longer in use.
Likely solution for #754.
Associated with the merging of this PR a note should be placed on the previous release about the introduction of this issue and that the solution is to update and use this function.