Clean up test step and exclude it from the "all" target #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaozg
approved these changes
Jan 24, 2025
|
Great, that indeed fixes it, thank you! Will you make a 1.50.0-1 release with this fix? |
|
Yep, would like to solve #751 / #742 (comment) first if possible, but not sure how long that'll end up taking |
|
Yeah, sorry, didn't see those before commenting. That absolutely makes sense. (Tests found another leak anyway, so I couldn't update to master even if I wanted now...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #733 (comment)