Add hints to generics in Route.respond #284
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
json
parameter toRoute.respond
is missing hints for theList
andDict
elements, which makespyright
sad in strict mode:This PR just adds the hints for the elements. I think python's
json.dump
will accept arbitrary key types, but the JSON spec only defines strings so I usedDict[str, ...]
. I'm happy to change that toAny
if you'd prefer.Thanks for the helpful library!