Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade yaserde to 0.12 #169

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

upgrade yaserde to 0.12 #169

wants to merge 2 commits into from

Conversation

Cyrix126
Copy link

Do not merge yet
Three breaking changes:

parameter namespace is now namespaces and can include multiple namespace.

#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]

This PR needs to be edited to take into account that multiples namespace must be included in one parameter.
Using this PR at the current state with multiple definition of namespace will generate incorrect code.

field attribute needs to have a boolean value instead of just being present.

    #[yaserde(attribute, prefix = "tns", rename = "id")]
    #[yaserde(attribute = true, prefix = "tns", rename = "id")]

name of encoding is now UTF-8 instead of utf-8.

        let s = r#"<?xml version="1.0" encoding="utf-8"?>
        let s = r#"<?xml version="1.0" encoding="UTF-8"?>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant