Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dialog): add fullHeight & fix styles on large heights #4505

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

zettca
Copy link
Member

@zettca zettca commented Jan 9, 2025

  • add fullHeight prop to make it easier to build full-height Dialogs
    • very useful to prevent layout shifts in "complex" dialogs
    • currently user has to do classes={{paper: "w-full"}}, which is a bit obscure
  • fix styles when HvDialog is larger/100%
    • Title/Actions is flexing, instead of content
  • fix Title styles when custom children content
  • make HvDialogActions using HvDialog's backgroundColor
  • apply new props/fixes to the Form example & use it in Chromatic
  • align chevron icon usage (Down -> DropDownXS)
  • fix section border

@zettca zettca requested a review from a team as a code owner January 9, 2025 15:09
@zettca zettca requested review from plagoa and francisco-guilherme and removed request for a team January 9, 2025 15:09
@zettca zettca changed the title feat(Dialog): add fullHeight & fix stlyes on large heights feat(Dialog): add fullHeight & fix styles on large heights Jan 9, 2025
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 15:15 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 15:15 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 15:23 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 15:23 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 16:01 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 16:01 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 16:33 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 16:33 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 18:12 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 18:12 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 18:27 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 18:27 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 19:26 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 19:26 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 20:05 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 20:05 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4505 January 9, 2025 20:41 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4505 January 9, 2025 20:41 Destroyed
@zettca zettca merged commit b4513d7 into master Jan 10, 2025
12 checks passed
@zettca zettca deleted the fix/styles branch January 10, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants