Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): improve baselines #4494

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat(cli): improve baselines #4494

merged 2 commits into from
Jan 10, 2025

Conversation

zettca
Copy link
Member

@zettca zettca commented Jan 3, 2025 •
edited
Loading

  • improve CLI & baselines:
    • i18next default languages & suspense
    • tsconfig improvements
    • bump packages with vulns/issues
    • add react-hooks ESLint rules
    • emotion css prop opt-in, aliging with UI Kit
  • remove unix link to /templates directory, in favor of copying directory on build
    • resolves some minor issues, like templates not working on Windows, double search results, TS errors, etc.
  • build(types): improve project tsconfig
    • leverage module: preserve presets
    • review strictness
    • remove redundant rules
    • allow proper package.json "exports" directory imports (useful for phosphor)

@zettca zettca requested a review from a team as a code owner January 3, 2025 11:03
@zettca zettca requested review from francisco-guilherme and MEsteves22 and removed request for a team January 3, 2025 11:03
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 3, 2025 11:08 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4494 January 3, 2025 11:09 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 3, 2025 11:28 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4494 January 3, 2025 11:28 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 6, 2025 15:39 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4494 January 6, 2025 15:39 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 7, 2025 10:27 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4494 January 7, 2025 10:27 Destroyed
@zettca zettca force-pushed the fix/stuff branch 2 times, most recently from d971ec4 to 584e966 Compare January 8, 2025 10:58
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 8, 2025 11:03 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4494 January 8, 2025 11:03 Destroyed
@zettca
feat(cli): improve baselines
77e6e2d 
- i18next default languages & suspense
- tsconfig
- bump packages with vulns/issues
- add react-hooks eslint
- emotion css prop opt-in
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 10, 2025 10:48 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4494 January 10, 2025 10:48 Destroyed
@zettca
build(cli): dedupe /templates directory
c2715a8 
- remove unix link in favor of copying directory on build
  - addresses Windows link issues
- add missing rimraf dependency & cpy
@github-actions github-actions bot temporarily deployed to uikit/pr-4494 January 10, 2025 11:28 Destroyed
@zettca zettca merged commit 8861283 into master Jan 10, 2025
12 checks passed
@zettca zettca deleted the fix/stuff branch January 10, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisco-guilherme francisco-guilherme francisco-guilherme approved these changes

@MEsteves22 MEsteves22 Awaiting requested review from MEsteves22 MEsteves22 is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zettca @francisco-guilherme