Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP adding music #52

Merged
merged 15 commits into from
Oct 27, 2024
Merged

WIP adding music #52

merged 15 commits into from
Oct 27, 2024

Conversation

Giesch
Copy link
Collaborator

@Giesch Giesch commented Oct 26, 2024

Adds basic effects for music streams. This comes with a few caveats:

  1. we leak music streams (like everything else); properly cleaning them up might need a new helper in roc
    https://roc.zulipchat.com/#narrow/channel/304641-ideas/topic/Host.20iteration.20access.20to.20roc.20resource.20heaps/near/479104637
  2. There's a nonsense Str error type in getMusicTimePlayed; this is working around the void tag compiler bug
  3. the 'restarting while paused' case in the example is weird because of a raylib issue;
    it looks like their example (or their music api?) has a bug where progress doesn't get reset,
    stopping a paused track resets the actual audio but not the played length

Also, the various music effects mostly share the permission enum for PlayMusic

@Giesch Giesch marked this pull request as ready for review October 27, 2024 21:40
@Giesch Giesch merged commit ff8bfef into main Oct 27, 2024
3 checks passed
@lukewilliamboswell lukewilliamboswell deleted the music branch October 27, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant