Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set default values in new participant form when user is logged in #1501

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jan 17, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced participant modal form with automatic user data pre-filling
    • Improved form usability by directly applying input field focus
  • Refactor

    • Simplified form initialization logic for logged-in users

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
landing ⬜️ Skipped (Inspect) Jan 17, 2025 11:32am

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Walkthrough

The pull request modifies the new participant modal component to integrate user authentication and streamline form initialization. By leveraging the useUser hook, the component now dynamically pre-fills form fields based on the user's login status. The changes simplify the form's initialization process by directly using user data and removing the previous manual focus management approach.

Changes

File Changes
apps/web/src/components/new-participant-modal.tsx - Added useUser hook import
- Introduced isLoggedIn variable
- Updated defaultValues to conditionally use user data
- Removed useMount hook
- Added autoFocus attribute to name input

Poem

🐰 A modal's dance, a user's grace,
Fields now fill with a seamless embrace
Logged in or not, the form knows best
No mounting hooks to pass the test
Simplicity reigns, with focus bright! 🎯


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/web/src/components/new-participant-modal.tsx (2)

96-106: Consider adding null checks and simplifying the default values logic.

While the implementation works, there are a few improvements that could make it more robust:

  1. Add null check for user.name to prevent potential issues
  2. Simplify the nested structure

Consider this more concise approach:

 const { register, setError, formState, handleSubmit } =
   useForm<NewParticipantFormData>({
     resolver: zodResolver(schema),
     defaultValues: {
       requireEmail: isEmailRequired,
-      ...(isLoggedIn
-        ? { name: user.name, email: user.email ?? "" }
-        : {
-            name: "",
-            email: "",
-          }),
+      name: isLoggedIn ? user.name ?? "" : "",
+      email: isLoggedIn ? user.email ?? "" : "",
     },
   });

140-140: Consider using shorthand boolean prop syntax.

The autoFocus implementation is good, but you can use the React shorthand syntax for boolean props.

-          autoFocus={true}
+          autoFocus
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aad31ff and 7dacc25.

📒 Files selected for processing (1)
  • apps/web/src/components/new-participant-modal.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Unit tests
  • GitHub Check: Linting
  • GitHub Check: Integration tests
  • GitHub Check: Type check
🔇 Additional comments (2)
apps/web/src/components/new-participant-modal.tsx (2)

18-18: LGTM!

The useUser hook import is correctly placed and follows the project's import conventions.


93-94: LGTM!

Clean and clear implementation of user authentication state using the useUser hook. The isLoggedIn derivation from !user.isGuest is logical and well-named.

@lukevella lukevella merged commit bbf9bae into main Jan 17, 2025
10 checks passed
@lukevella lukevella deleted the prefill-participant-form branch January 17, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant